Post by Admin on Jul 16, 2016 4:16:22 GMT
Simon Schmid @sschmid Sep 08 2015 22:59
I guess we're bringing back AnyOf and NoneOf matchers, similar to
Matcher.AllOf(A, B).AnyOf(C, D).NoneOf(E, F)
CodePoKE @gjroelofs Sep 08 2015 23:00
Thanks for the heads up; I'll stop work on it from my end then.
Btw, was there a specific reason as to why you didn't merge the PR and instead opted to commit your own code?
(Just curious whether this is the policy in general, as then I don't have to submit PRs :-) )
Simon Schmid @sschmid Sep 08 2015 23:03
In this case I fetched it but the tests didn't pass and I was faster just adding tests and the allPools getter, instead of comparing and updating the PR.
besides that, I'm happy to merge PRs
CodePoKE @gjroelofs Sep 08 2015 23:05
Fair enough
It might be interesting to start looking into test builds across multiple platforms as the PR came through the local tests, but failed in Travis.
Simon Schmid @sschmid Sep 08 2015 23:13
Yes, I managed to get a windows pc. Will look into that soon
Simon Schmid @sschmid Sep 08 2015 23:49
downloading cygwin…how can ppl even work on windows
CodePoKE @gjroelofs Sep 08 2015 23:54
95% of my work is on Arch, hence Artemis & Xtend; I only have Windows installed for contract work on Unity.
I guess we're bringing back AnyOf and NoneOf matchers, similar to
Matcher.AllOf(A, B).AnyOf(C, D).NoneOf(E, F)
CodePoKE @gjroelofs Sep 08 2015 23:00
Thanks for the heads up; I'll stop work on it from my end then.
Btw, was there a specific reason as to why you didn't merge the PR and instead opted to commit your own code?
(Just curious whether this is the policy in general, as then I don't have to submit PRs :-) )
Simon Schmid @sschmid Sep 08 2015 23:03
In this case I fetched it but the tests didn't pass and I was faster just adding tests and the allPools getter, instead of comparing and updating the PR.
besides that, I'm happy to merge PRs
CodePoKE @gjroelofs Sep 08 2015 23:05
Fair enough
It might be interesting to start looking into test builds across multiple platforms as the PR came through the local tests, but failed in Travis.
Simon Schmid @sschmid Sep 08 2015 23:13
Yes, I managed to get a windows pc. Will look into that soon
Simon Schmid @sschmid Sep 08 2015 23:49
downloading cygwin…how can ppl even work on windows
CodePoKE @gjroelofs Sep 08 2015 23:54
95% of my work is on Arch, hence Artemis & Xtend; I only have Windows installed for contract work on Unity.