Post by Admin on Jul 16, 2016 3:44:34 GMT
Marcel @marcelmalik Aug 21 2015 17:27
Hello Entitas Group
Maxim Zaks @mzaks Aug 21 2015 18:02
Hi
Arvid Backman backman Aug 21 2015 18:03
Eyo!
Simon Schmid @sschmid Aug 21 2015 18:05
Hey!
Maxim Zaks @mzaks Aug 21 2015 18:09
@judelco the discussion were very long
We went with the simplest solution: dumping the pooling of destroyed entities because it solves the problem in the simplest manner.
However if you see that destroying entities makes you GC spike. (normally it should not be the case) You can still enable it by ENTITAS_ENTITY_OBJECT_POOL flag. However in this case you certainly know what you are doing and aware that you should not change destroyed entities.
JuDelCo @judelco Aug 21 2015 22:14
I see, well then I hope GC wont be a bit naughty too xD
Maxim Zaks @mzaks Aug 21 2015 22:31
Normally it should not. Only if you simulate nuclear blast or something
JuDelCo @judelco Aug 21 2015 22:32
I'm currently making a shmup with buuuuuulllets
Anyway i like the idea of an entity pool, maybe i will keep a custom entitas repo with it and my changes
Simon Schmid @sschmid Aug 21 2015 22:34
You can still opt in with ENTITAS_ENTITY_OBJECT_POOL. It's just disabled by default, to prevent issues you might run into, when you new to entitas. But maybe we figure out a nice solution soon
JuDelCo @judelco Aug 21 2015 22:35
Yes, but it still have #25 issue
Anyway this solution is good
for newcomers
Maxim Zaks @mzaks Aug 21 2015 22:36
the main point against your solution was that you kind of couple Pool with the systems. Not directly but pool waits for someone to tell it that now it is safe to reuse.
JuDelCo @judelco Aug 21 2015 22:36
yes, but it can be done manually too
Maxim Zaks @mzaks Aug 21 2015 22:38
I guess but than it becomes a bit more complex. As @sschmid sad we are still thinking about it, we just want to find the most simple and elegant solution. That takes time and "meditation"
Hello Entitas Group
Maxim Zaks @mzaks Aug 21 2015 18:02
Hi
Arvid Backman backman Aug 21 2015 18:03
Eyo!
Simon Schmid @sschmid Aug 21 2015 18:05
Hey!
Maxim Zaks @mzaks Aug 21 2015 18:09
@judelco the discussion were very long
We went with the simplest solution: dumping the pooling of destroyed entities because it solves the problem in the simplest manner.
However if you see that destroying entities makes you GC spike. (normally it should not be the case) You can still enable it by ENTITAS_ENTITY_OBJECT_POOL flag. However in this case you certainly know what you are doing and aware that you should not change destroyed entities.
JuDelCo @judelco Aug 21 2015 22:14
I see, well then I hope GC wont be a bit naughty too xD
Maxim Zaks @mzaks Aug 21 2015 22:31
Normally it should not. Only if you simulate nuclear blast or something
JuDelCo @judelco Aug 21 2015 22:32
I'm currently making a shmup with buuuuuulllets
Anyway i like the idea of an entity pool, maybe i will keep a custom entitas repo with it and my changes
Simon Schmid @sschmid Aug 21 2015 22:34
You can still opt in with ENTITAS_ENTITY_OBJECT_POOL. It's just disabled by default, to prevent issues you might run into, when you new to entitas. But maybe we figure out a nice solution soon
JuDelCo @judelco Aug 21 2015 22:35
Yes, but it still have #25 issue
Anyway this solution is good
for newcomers
Maxim Zaks @mzaks Aug 21 2015 22:36
the main point against your solution was that you kind of couple Pool with the systems. Not directly but pool waits for someone to tell it that now it is safe to reuse.
JuDelCo @judelco Aug 21 2015 22:36
yes, but it can be done manually too
Maxim Zaks @mzaks Aug 21 2015 22:38
I guess but than it becomes a bit more complex. As @sschmid sad we are still thinking about it, we just want to find the most simple and elegant solution. That takes time and "meditation"
